[Freeciv-Dev] Re: (PR#2430) Nation popup show negative income

["ChrisK@xxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

On Thu, Nov 28, 2002 at 02:56:00PM -0800, Jason Short via RT wrote:
> On Thu, 2002-11-28 at 17:34, Christian Knoke wrote:
> > On Thu, Nov 28, 2002 at 02:34:11PM -0800, Jason Short via RT wrote:
> > > On Thu, 2002-11-28 at 17:26, ChrisK@xxxxxxxx via RT wrote:
> > > > On Thu, Nov 28, 2002 at 02:12:57PM -0800, Jason Short via RT wrote:
> > > > > 
> > > > > [ChrisK@xxxxxxxx - Wed Nov 27 12:54:03 2002]:
> > > > > 
> > > > > > CVS 27 NOV 2002 BETA/Stable branch GTK 1.2
> > > > > > 
> > > > > > Sometimes the net income shows a negative value (in despotism)
> > > > > > while F5 shows correctly a positive income.
> > > > > 
> > > > > Err, I don't quite understand...
> > > > > 
> > > > > What nation popup shows the negative value?  Which is correct?
> > > > 
> > > > Well, that, if you click with left mouse button on the text below
> > > > the minimap, that popup. I've had negative values here for income,
> > > > right in the beginning of the game, with a few cities and nearly
> > > > no buildings - silly me I haven't saved that, sorry.
> > > 
> > > This popup shows you turn_gold_difference, whereas F5 shows your actual
> > > calculated income.
> > 
> > F5 shows income and costs, not the difference.
> 
> Right...
> 
> Perhaps "income" in the economy dialog should be retitled "revenue"?  Or
> "gross income"?  (This is clearly a English-specific change.)

I leave this to the native english.

> > > turn_gold_difference is how much money you made/lost the _previous_
> > > turn.  This also includes stuff like finding gold in huts.
> > 
> > Does this mean, if I buy things, this goes down? It is quite
> > possible that I did buy something in that game, but the costs of
> > buildings definitely can't have been so high that I got -14 income.
> 
> Yes, if you buy something, your "Net Income" the next turn will be
> reported as lower.

So that's why it's negative.

> > > Is this a bug?  Should the calculated income be used instead of
> > > turn_gold_difference?  Is there a global function for calculating the
> > > expected income?
> > 
> > Dunno.
> 
> Surely you have an opinion on the first question? :-)

That depends on :) I'd say it should display the "general", "expected"
income. Buys shouldn't sum up here.

> jason

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.