[Freeciv-Dev] Re: Ping

[Thomas Strub <ue80@xxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 29, 2002 at 10:09:38AM +0100, Raimar Falke wrote:
> On Mon, Oct 28, 2002 at 09:33:39PM +0100, Thomas Strub wrote:
> > Hi,
> > 
> > as client-servergame freeciv should show the pings of all the players.
> > 
> > Things in my implementation where people could say make it different:
> > gettimeofday on server is essential but nowhere verified. 
> 
> > The timers of common/timing  aren't used.
> 
> Please use it.

I really don't like the "double sec" in timing.c 
> 
> > The PACKET_CONN_PING isn't used. (created a new one)
> 
> Why?

PACKET_CONN_PING is used to cut people after some time if they are not
responding. PACKET_PING is to get and send the Ping information. Think
its possible to do it with the same packet.
 
> > No sequence number in the ping packet.
> > Ping packet every 3 seconds and not as player option.
> 
> Please make it a server option or just use pingtimeout.

Making a server option is much work ... so i first wanted that it works.
Now i will look that it works and the maintainers are happy with that.

> > +    my_snprintf(pingbuf, sizeof(pingbuf),"   %6d,%02d ms", 
> > game.players[i].ping_time/100, game.players[i].ping_time%100);
> 
> Here i18n is missing. It is "45.1ms" in english for example.

Ok.

Thomas