[Freeciv-Dev] Re: Ping

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Mon, Oct 28, 2002 at 09:33:39PM +0100, Thomas Strub wrote:
> Hi,
> 
> as client-servergame freeciv should show the pings of all the players.
> 
> Things in my implementation where people could say make it different:
> gettimeofday on server is essential but nowhere verified. 

> The timers of common/timing  aren't used.

Please use it.

> The PACKET_CONN_PING isn't used. (created a new one)

Why?

> No sequence number in the ping packet.
> Ping packet every 3 seconds and not as player option.

Please make it a server option or just use pingtimeout.

> +    my_snprintf(pingbuf, sizeof(pingbuf),"   %6d,%02d ms", 
> game.players[i].ping_time/100, game.players[i].ping_time%100);

Here i18n is missing. It is "45.1ms" in english for example.

There are also some style problems.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Any sufficiently advanced technology is indistinguishable from magic."
    -- Arthur C. Clarke