[Freeciv-Dev] Re: new unit flags, 13th version of the patch (PR#1324)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Wed, 21 Aug 2002, Reinier Post wrote:
> F_UNIQUE means "having a unit of a type with this flag,
> a player can never build a second unit of that type".
> You check this in can_player_build_unit_direct().
>
> But a player can also get such a unit by
>
> - bribing it

If you wish to avoid this, make it F_UNBRIBABLE. Implementation defined.

> - getting the city that owns it

If you wish to avoid this, make it F_SUPERSPY and/or F_NOHOME.
Implementation defined.

> - getting the city that is building it

That should not be possible anymore. It will check.

> - finding it in a hut

Only if you give it the L_HUT flag.

> You probably need to check this explicitly.

I did once, but then I split this up into several flags instead.

> Also, if such a unit takes very long to build and
> cannot be moved (sort of an improvement), it is
> reasonable to allow the player to start building
> a replacement.

We may not want this for units that are not stationary, however. For a few
modpacks, building a replacement will look outright silly. These are
usually heroes or personalities, of which there is only one.

> BTW with a F_UNIQUE_PER_CITY flag,
> improvements can be turned into units ...

Maybe in freeciv 1.25.0 or something?

Yours
Per