[Freeciv-Dev] Re: Barbarians in huts if Barbarians disabled (PR#1869)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

C. McCohy wrote:
> > > Right now you have about 8 percent chance that you unit will be killed or
> > > a horde of Barbarians will appear. Who wants to have such risk in the
> > > game, he can set the barbarians variable to non-zero value, who wants
> > > not, he should be able to disable it ... hnnmmnn ..
> > I agree. Could you provide a patch that adds this as another option (one
> > that doesn't wipe out the option of having barbarians only in huts)?
>
> Sure, here it is ... option "barbsinhuts" patch against CVS tree
The option should be a bool, not an int:

    #define GAME_DEFAULT_BARBSINHUTS 1
    =>   #define GAME_DEFAULT_BARBSINHUTS TRUE

    int barbsinhuts;
    =>   bool barbsinhuts;

    secfile_insert_int => secfile_insert_bool (maybe?)

    GEN_INT => GEN_BOOL

    if(game.barbsinhuts == 0) {
    =>   if (!game.barbsinhuts) {

Such style/readibility issues are thought hightly of by (at least some
of) the freeciv maintainers.

jason