[Freeciv-Dev] Re: Barbarians in huts if Barbarians disabled (PR#1869)

["Anthony J. Stuckey" <astuckey@xxxxxxxx>]

On Fri, Aug 02, 2002 at 12:10:34PM -0500, Anthony J. Stuckey wrote:
> On Fri, Aug 02, 2002 at 08:13:08AM +0200, C. McCohy wrote:
> > > > Right now you have about 8 percent chance that you unit will be killed 
> > > > or
> > > > a horde of Barbarians will appear. Who wants to have such risk in the
> > > > game, he can set the barbarians variable to non-zero value, who wants
> > > > not, he should be able to disable it ... hnnmmnn ..
> > >
> > > I agree. Could you provide a patch that adds this as another option (one
> > > that doesn't wipe out the option of having barbarians only in huts)?
> > 
> > Sure, here it is ... option "barbsinhuts" patch against CVS tree
> > (already tested and well working):
> 
>       Am I missing something?  Why is this code not working as described?
> 
> http://www.freeciv.org/lxr/source/ChangeLog#L24602
> 
> 24595 Tue Feb 15 14:21:10 2000  Jeff Mallatt <jjm@xxxxxxxxxxxx>:
> 24596 24597 * common/game.c, common/game.h, server/barbarian.c,
> 24598 server/gamehand.c, server/stdinhand.c, server/unithand.c:
> 24599
> 24600 Provide more control over barbarians.  It does two things:
> 24601
> 24602 - The server option "barbarians" is changed so that 0 means no
> 24603 barbarians at all, 1 means barbarians only in huts, 2 is normal, 3
> 24604 is more, 4 is lots.
> 24605
> 24606 - A new server option "onsetbarbs" specifies a year before which
> 24607 no barbarians will appear.  This lets all civs get going without
> 24608 one being so unlucky as to have barbarians pop up and destroy it
> 24609 before it even gets started.  I think this will help game balance
> 24610 for multi-human games, and will also help newbies get started.
> 24611
> 24612 Complaint registered by Massimo Campostrini
> 24613 <campo@xxxxxxxxxxxxxxxxxxxxx>.

        It appears that server/unittools.c:hut_get_barbarians() fails to check
game.barbarianrate or game.onsetbarbarian.  Thus the attached (untested)
patch would seem to fix this bug.

barbarian.patch
Description: Text document