Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2002:
[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)
Home

[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)
From: Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 16 May 2002 09:07:45 -0500

On Thu, May 16, 2002 at 03:10:27PM +0200, Raimar Falke wrote:
> On Thu, May 16, 2002 at 01:40:29PM +0100, Ben Webb wrote:
> > On Thu, May 16, 2002 at 02:35:33PM +0200, Raimar Falke wrote:
> > > Ok I agree that the proposed solution was too fragile. What about this
> > > one?
> > 
> >     Looks better, although you're still not freeing player.effects
> > and player.island_effects at all, unless you're proposing to apply my
> > patch on top of this one.
> 
> What about the attached patch? I'm sure I have broken something other
> this time.
> 

why aren't we simply calling a client_cleanup function that frees
everything that needs to be freed and call it on disconnect. This is much 
better than special-casing the code to death.

This is probably going to have to happen eventually anyway. It seems much 
better than putting flags in game_init()

-mike


[Prev in Thread] Current Thread [Next in Thread]