[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Thu, May 16, 2002 at 03:10:27PM +0200, Raimar Falke wrote:
> On Thu, May 16, 2002 at 01:40:29PM +0100, Ben Webb wrote:
> > On Thu, May 16, 2002 at 02:35:33PM +0200, Raimar Falke wrote:
> > > Ok I agree that the proposed solution was too fragile. What about this
> > > one?
> >
> > Looks better, although you're still not freeing player.effects
> > and player.island_effects at all, unless you're proposing to apply my
> > patch on top of this one.
>
> What about the attached patch? I'm sure I have broken something other
> this time.
>
why aren't we simply calling a client_cleanup function that frees
everything that needs to be freed and call it on disconnect. This is much
better than special-casing the code to death.
This is probably going to have to happen eventually anyway. It seems much
better than putting flags in game_init()
-mike
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), (continued)
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/15
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Mike Kaufman, 2002/05/15
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/15
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Mike Kaufman, 2002/05/15
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Ben Webb, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Ben Webb, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Ben Webb, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434),
Mike Kaufman <=
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Ben Webb, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Mike Kaufman, 2002/05/16
- [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434), Raimar Falke, 2002/05/16
|
|