Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2002:
[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)
Home

[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)
From: Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 May 2002 15:57:34 -0500

On Wed, May 15, 2002 at 10:28:00PM +0200, Raimar Falke wrote:
> On Wed, May 15, 2002 at 03:17:45PM -0500, Mike Kaufman wrote:
> > On Wed, May 15, 2002 at 10:09:45PM +0200, Raimar Falke wrote:
> > > On Sat, May 11, 2002 at 12:59:15AM -0500, Mike Kaufman wrote:
> > > > we already have a [smaller] memory leak when diconnecting and
> > > > reconnecting to the server (or quitting the server and restarting it).
> > > > this "fix" really intensifies the memory leak---depending on the
> > > > savegame size---by about an order of magnitude.
> > > 
> > > Here is a second fix. There are no additional memory leaks by calling
> > > game_init.
> > 
> > how about just changing _init to do an unlink_all first instead of creating
> > a new (redundant) call for _reinit? 
> 
> This may cover other bugs. Although I have no idea how much remote
> this is.

Possibly, but if we were recalling _init anywhere _and_ it was causing a
problem,  we would have known about it before now.

try it and run a couple autogames, and screw around in the client to see if
anything wigs out.

-mike


[Prev in Thread] Current Thread [Next in Thread]