[Freeciv-Dev] Re: Wonder obsolesence across games (PR#1434)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, May 16, 2002 at 09:07:45AM -0500, Mike Kaufman wrote:
> On Thu, May 16, 2002 at 03:10:27PM +0200, Raimar Falke wrote:
> > On Thu, May 16, 2002 at 01:40:29PM +0100, Ben Webb wrote:
> > > On Thu, May 16, 2002 at 02:35:33PM +0200, Raimar Falke wrote:
> > > > Ok I agree that the proposed solution was too fragile. What about this
> > > > one?
> > > 
> > >   Looks better, although you're still not freeing player.effects
> > > and player.island_effects at all, unless you're proposing to apply my
> > > patch on top of this one.
> > 
> > What about the attached patch? I'm sure I have broken something other
> > this time.
> > 
> 
> why aren't we simply calling a client_cleanup function that frees
> everything that needs to be freed and call it on disconnect. This is much 
> better than special-casing the code to death.
> 
> This is probably going to have to happen eventually anyway. It seems much 
> better than putting flags in game_init()

It doesn't matter how we call this function. The code have to be
somewhere.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "When C++ is your hammer, everything looks like a thumb."
    -- Steven M. Haflich