[Freeciv-Dev] Re: new_natural_city_names updated again (PR#1127)

[Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Apr 09, 2002 at 11:46:28AM -0700, Jason Short wrote:
> per@xxxxxxxxxxx wrote:
> > On Tue, 9 Apr 2002, Jason Short wrote:
> > 
> >>This is another update of the new natural city names patch to current
> >>CVS.  Nothing has really changed; see all the old discussion for an
> >>explanation.
> > 
> > 
> > +struct city_name {
> > +   char* name;
> > +   int river;
> > +   int terrain[T_COUNT];
> > +};
> > 
> > Can you make it char name[MAX_LEN_NAME] instead? Fewer allocations
> > better.
> 
> Are you sure?  This will take more memory on average (even considering 
> the overhead for a malloc), and will make the termination code (even) 
> more ugly (the city_name array is currently terminated by a NULL name).

I'm not against the malloc, unless Per can elaborate on the disadvantages.

> 
> > +  GEN_BOOL("naturalcitynames", game.natural_city_names,
> > +           SSET_RULES_FLEXIBLE, SSET_TO_CLIENT,
> > +           N_("Whether to use natural city names"),
> > +           N_("If enabled, the default city names will be determined based 
> > "
> > +              "on the surrounding terrain."),
> > +           NULL, GAME_DEFAULT_NATURALCITYNAMES)
> > +
> > 
> > IMHO, you can just make this the default. Why wouldn't anyone want this?
> > (And even if they didn't want it, would they bother enough to turn it
> > off? I doubt it.) I don't like unnecessary "options creep".

bah. :)

> 
> Well, it is the "default".
> 
> It would be fine IMO to remove the server option.  But since it was so 
> easy I added it in.  The reason someone might not want this is that it 
> does tend to change the capital city's name (although within reason, 
> unlike the original natural_city_names patch, and it can be manually 
> changed back).  Anyone else with a preference?

Personally I appreciate playing with Rome as my capital, so I might turn it
off. Keep the option.

-mike