[Freeciv-Dev] Re: new_natural_city_names updated again (PR#1127)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Apr 09, 2002 at 09:16:41AM -0500, Mike Kaufman wrote:
> > I hate to say it, because I like this a lot myself, but this should be
> > 
> >   while (name != NULL && strlen(name) > 0)
> 
> na, we decided that if (!ptr) and if (ptr) is ok, to avoid lots o' cruft.  
> It should be ansi and all that jazz.

Yes.

As to the other construct: it stands 14 (strlen) against 50
(*s=='\0'). I would prefer a macro but Vasc was against it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  (On the statement print "42 monkeys"+"1 snake"): BTW, both perl and Python
  get this wrong. Perl gives 43 and Python gives "42 monkeys1 snake", when 
  the answer is clearly "41 monkeys and 1 fat snake".  
    -- Jim Fulton, 10 Aug 1999