[Freeciv-Dev] Re: a few notify fixes

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

If enum order == absolute number is critical, then all enum values
should be assigned. This way there is no problem no matter what you
do. Deletions will have no effect.

Cheers,
RossW
=====

At 11:07 PM 02/04/03 +0200, Raimar Falke wrote:
>On Wed, Apr 03, 2002 at 02:26:12PM -0600, Mike Kaufman wrote:
>> On Wed, Apr 03, 2002 at 09:47:08PM +0200, Raimar Falke wrote:
>> > 
>> > > diff -u3NrX /home/perrin/freeciv/diff_ignore freeciv/common/events.h
freeciv-phased/common/events.h
>> > > --- freeciv/common/events.h      Tue Mar 26 01:34:22 2002
>> > > +++ freeciv-phased/common/events.h       Wed Apr  3 00:46:27 2002
>> > > @@ -35,6 +35,7 @@
>> > >    E_UNIT_BUILD,
>> > >    E_UNIT_LOST,
>> > >    E_UNIT_WIN,
>> > > +  E_UNIT_RELOCATED,
>> > >    E_ANARCHY,
>> > >    E_DIPLOMATED,
>> > >    E_TECH_GAIN,
>> > > @@ -51,7 +52,6 @@
>> > >    E_SPACESHIP,
>> > >    E_UPRISING,
>> > >    E_WORKLIST,
>> > > -  E_CANCEL_PACT,
>> > >    E_DIPL_INCIDENT,
>> > >    E_FIRST_CONTACT,
>> > >    E_CITY_MAY_SOON_GROW,
>> > 
>> > These aren't. Only append or rename but not remove.
>> 
>> ugh. what's this going to break? Answer: civclientrc.
>
>And the network protocol. Events are transferred by number. They get
>their number by the order they occour in this enum. You may add " =
>456" to them but this even uglier. If you want to remove an event
>either add a mandatory capability or rename the symbol to E_RETIRED0
>or similar.
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "On the eigth day, God started debugging"