[Freeciv-Dev] Re: a few notify fixes

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Apr 03, 2002 at 06:47:47PM -0500, Daniel L Speyer wrote:
> On Wed, 3 Apr 2002, Mike Kaufman wrote:
> 
> > On Wed, Apr 03, 2002 at 09:47:08PM +0200, Raimar Falke wrote:
> > > 
> > > > diff -u3NrX /home/perrin/freeciv/diff_ignore freeciv/common/events.h 
> > > > freeciv-phased/common/events.h
> > > > --- freeciv/common/events.h     Tue Mar 26 01:34:22 2002
> > > > +++ freeciv-phased/common/events.h      Wed Apr  3 00:46:27 2002
> > > > @@ -35,6 +35,7 @@
> > > >    E_UNIT_BUILD,
> > > >    E_UNIT_LOST,
> > > >    E_UNIT_WIN,
> > > > +  E_UNIT_RELOCATED,
> > > >    E_ANARCHY,
> > > >    E_DIPLOMATED,
> > > >    E_TECH_GAIN,
> > > > @@ -51,7 +52,6 @@
> > > >    E_SPACESHIP,
> > > >    E_UPRISING,
> > > >    E_WORKLIST,
> > > > -  E_CANCEL_PACT,
> > > >    E_DIPL_INCIDENT,
> > > >    E_FIRST_CONTACT,
> > > >    E_CITY_MAY_SOON_GROW,
> > > 
> > > These aren't. Only append or rename but not remove.
> > 
> > ugh. what's this going to break? Answer: civclientrc. so what? We should
> > break it now before release. Since Per wants now fine-grained events for
> > diplomats anyway, and that will require removing the other diplo events, we
> > should do it. (oh, and since you did that business in options.c, we can
> > stop naming all the events in civclientrc by numbers, so in the future, we
> > can add/remove events with no problems.)
> > 

> Please remember the message-icons patch.  It handles added events pretty
> gracefully, but it'll fail compilation if events are removed or renamed,
> and it may look silly if events get split up.

AFAI remember the last status was that I requested that the code is
moved to a common location. And the author said: I will do it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Your mail could not be delivered to the following Address:
  VTCMC.VTLPR@xxxxxxxxxxxxx        ** Unassigned error message **"