[Freeciv-Dev] Re: Patches on the city report

[Christian Knoke <chrisk@xxxxxxxx>]

On Wed, Mar 13, 2002 at 11:02:24AM -0600, Mike Kaufman wrote:
> On Wed, Mar 13, 2002 at 01:29:01PM +0100, Christian Knoke wrote:
> > (I lost the messages somehow)
> > 
> > I applied both of Mike's patches for the city report.
> > 
> > I like very much the way you did the select / change (menu patch)
> > Unfortunately it dumps core often when doing a select:
> > 
> > I did select->city improvements->barracks II and got:
> 
> hmm, is this just for select, and just for barracks II?, just improvements,
> or for units and/or wonders too? send me a savegame that exhibits this
> behavior.

PM follows

[...]

> > 
> > 
> > I'm not so convinced with the sorting patch, because it is confusing
> > (and I wrote that about Raimar's version) to find out what is sorted
> > how. And I think it is difficult to make it good.
> 
> yes, difficult.
> 
> > I would be happy if the sorting would be done only with the *first*
> > item of a column, (maybe take the 2nd coulumn as a 2nd criteria)
> > but *correct*, i.e. numerically, not alphabetically (as it is now
> > without your patch).
> 
> but it's not correct numerically now. 0 will be sorted last and 12 will be
> sorted before 9.

That's what I wanted to say. Your patch repairs it and that's fine.
I'd be content with that fix only.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.