Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2002:
[Freeciv-Dev] Patches on the city report

[Freeciv-Dev] Patches on the city report

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv Developers <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Patches on the city report
From: Christian Knoke <chrisk@xxxxxxxx>
Date: Wed, 13 Mar 2002 13:29:01 +0100

(I lost the messages somehow)

I applied both of Mike's patches for the city report.

I like very much the way you did the select / change (menu patch)
Unfortunately it dumps core often when doing a select:

I did select->city improvements->barracks II and got:

(gdb) bt
#0  0x00000000 in ?? ()
#1  0x0807ce7c in select_impr_or_unit_callback (w=0x846aff4, data=0x5) at
#2  0x400e13c3 in gtk_marshal_NONE__NONE () from /usr/lib/
#3  0x40113268 in gtk_handlers_run () from /usr/lib/
#4  0x4011263f in gtk_signal_real_emit () from /usr/lib/
#5  0x40110597 in gtk_signal_emit () from /usr/lib/
#6  0x4014964f in gtk_widget_activate () from /usr/lib/
#7  0x400e9efc in gtk_menu_shell_activate_item () from
#8  0x400e9121 in gtk_menu_shell_button_release () from
#9  0x400e0f2f in gtk_marshal_BOOL__POINTER () from /usr/lib/
#10 0x4011267d in gtk_signal_real_emit () from /usr/lib/
#11 0x40110597 in gtk_signal_emit () from /usr/lib/
#12 0x401494ec in gtk_widget_event () from /usr/lib/
#13 0x400e0e65 in gtk_propagate_event () from /usr/lib/
#14 0x400dfeaf in gtk_main_do_event () from /usr/lib/
#15 0x40194dd4 in gdk_event_dispatch () from /usr/lib/
#16 0x401c6c46 in g_main_dispatch () from /usr/lib/
#17 0x401c7273 in g_main_iterate () from /usr/lib/
#18 0x401c743c in g_main_run () from /usr/lib/
#19 0x400df76c in gtk_main () from /usr/lib/
#20 0x0808deb4 in ui_main (argc=3, argv=0xbffff604) at gui_main.c:867
#21 0x0805fa91 in main (argc=3, argv=0xbffff604) at civclient.c:194
#22 0x403277ee in __libc_start_main () from /lib/

I'm not so convinced with the sorting patch, because it is confusing
(and I wrote that about Raimar's version) to find out what is sorted
how. And I think it is difficult to make it good.

I would be happy if the sorting would be done only with the *first*
item of a column, (maybe take the 2nd coulumn as a 2nd criteria)
but *correct*, i.e. numerically, not alphabetically (as it is now
without your patch).

Just my 2 euro cents


Christian Knoke     * * *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

[Prev in Thread] Current Thread [Next in Thread]