[Freeciv-Dev] Re: == NULL && != NULL

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Feb 10, 2002 at 01:52:26PM -0500, Greg Wooledge wrote:
> Raimar Falke (hawk@xxxxxxxxxxxxxxxxxxxxxxx) wrote:
> 
> > No. But there are some constructs like "int c; .... if(c)" which
> > bother splint.
> 
> I'd like to point out that there's a big difference between this:
> 
>   int c;
>   if (c) do_something();
> 
> and this:
> 
>   int is_blue;
>   if (is_blue) do_something();
> 
> At least IMHO.

Ack. Main culprits here are "punit->fuel", "punit->moves_left",
"punit->homecity", "pcity->did_buy" (no this one isn't a bool) and a
lot of simple counters (especially in AI code). So the is_*s aren't
the problem.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  This customer comes into the computer store. "I'm looking for a mystery
  Adventure Game with lots of graphics. You know, something realy
  challenging". "Well," replied the clerk, "have you tried Windows 98 ?"