[Freeciv-Dev] Re: == NULL && != NULL

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Sun, Feb 10, 2002 at 10:27:21AM CET, I got a letter,
where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> On Sun, Feb 10, 2002 at 01:15:40AM +0000, Vasco Alexandre Da Silva Costa 
> wrote:
> > 
> > Why the extra cruft?
> 
> For the same reason as the previous s/0/NULL/ change: to make it explicit.

And what's the value of making this explicit? It's ok for integer values, but I
believe it has no great value for pointers. Some level of 'explicity' is good,
but too much explicit stuff makes code exponentially less readable and longer
and way too verbose.

At least I believe that such a relatively major change should be first
discussed on the mailing list and general consensus should be reached.
According to the reactions it looks more people are unhappy than happy (the
unhappy people are usually more active and visible than the happy, though ;). I
would probably send more NULLs^Wworkers back home (and make elvises from them).

> > Is it to make the new lint happy?
> 
> Yes. And to allow other changes like the introduction of bool types.

In which way it will help booleans?

> > I can live with it, but its annoying.
> 
> About bool types: I will commit today or tomorrow a patch which
> changes 0 to FALSE and 1 to TRUE. But this will only be the first
> step. The next step is the introduction of an type bool. Comments?

I'm ok with the boolean.

Kind regards,

-- 

                                Petr "Pasky" Baudis

* UN*X programmer && admin         * IPv6 guy (XS26 co-coordinator)
* elinks maintainer                * FreeCiv AI hacker
* IRCnet operator
.
I love deadlines.
I love the whooshing sound they make as they fly by.
-- Douglas Adams.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/