[Freeciv-Dev] Re: Small patch to AI Manage functions

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Sat, Feb 09, 2002 at 07:42:21PM CET, I got a letter,
where Zach Garner <zach@xxxxxxxxxxxxx> told me, that...
> > >   2.  I've changed from ai_manage_explorer(unit *) to
> > > ai_manage_explorer(player *, unit *) to be consistent with other
> > > ai_manage functions. Before the change, unit_owner(punit) had to be
> > > computed every time ai_manage_explorer was called.
> > 
> > I feel relatively neutral with this. Something wrong with the current 
> > fashion?
> 
> It's really insignificant. From aiunit.c there is
>    ai_manage_barbarian_leader(struct player, struct unit)   
>    ai_manage_diplomat(struct player, struct unit)
>    ai_manage_military(struct player, struct unit)
>    ai_manage_caravan(struct player, struct unit)
>    ai_manage_explorer(struct unit)
> 
> So all of the ai_manage_TYPE functions take two arguments except
> ai_manage_explorer. All I am proposing is that this be made consistent.
> Either require player as an argument, or call unit_owner(punit) within
> all of the ai_manage_TYPE functions

True, so be it. I feel ok with the patch.

-- 

                                Petr "Pasky" Baudis

* UN*X programmer && admin         * IPv6 guy (XS26 co-coordinator)
* elinks maintainer                * FreeCiv AI hacker
* IRCnet operator
.
I love deadlines.
I love the whooshing sound they make as they fly by.
-- Douglas Adams.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/