[Freeciv-Dev] Re: Small patch to AI Manage functions

[Zach Garner <zach@xxxxxxxxxxxxx>]

> Mmm.  But still a unit can do nothing with no moves.  Why bother calling
> ai_manage_specific_type at all?

I guess its just my personal preference. To explain the way I think
about it:  For functions like ai_manage_caravan, there are conditions
which a unit needs to do something even though there are no moves left.
If at a later time, military units do require some kind of processing,
even though there are no moves left, I'd rather not have to modify the
calling functions just to get it to work correctly. This is an
encapsulation issue..

In ai_manage_caravan, the fist line of real code is:
  if (punit->activity != ACTIVITY_IDLE) return;
why not put this in ai_manage_unit as well as testing for moves_left?


Zach Garner