[Freeciv-Dev] Re: Activeunits patch version 2

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jan 14, 2002 at 02:46:13PM -0500, Daniel L Speyer wrote:
> On Mon, 14 Jan 2002, Raimar Falke wrote:
> 
> > On Sat, Jan 05, 2002 at 05:59:54PM -0500, Daniel L Speyer wrote:
> > > Here is the next patch for the activeunits dialog.  It adds a limited find
> > > next capability (it is only reset by changing which unit you're looking
> > > for) and a wake sentried button.  Various work remains, but this seems
> > > ready to send out.  
> > 
> > Overall: it goes in the right direction. Keep going.
> > 
> > Problems:
> > 
> > gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I. -I./.. -I./../include 
> > -I../../common -I../../intl -I/usr/lib/glib/include -I/usr/X11R6/include 
> > -I/usr/X11R6/include  -Wall -Wpointer-arith -Wcast-align 
> > -Wmissing-prototypes -Wmissing-declarations -Werror  -g -O2 -Wall -c 
> > repodlgs.c
> > cc1: warnings being treated as errors
> > repodlgs.c:986: warning: no previous prototype for `unit_present'
> > repodlgs.c:1004: warning: no previous prototype for 
> > `activeunits_find_next_callback'
> > repodlgs.c:1071: warning: no previous prototype for 
> > `activeunits_change_prod_close_callback'
> > repodlgs.c:1081: warning: no previous prototype for 
> > `activeunits_change_prod_close_button_callback'
> > repodlgs.c:1089: warning: no previous prototype for 
> > `activeunits_change_prod_change_callback'
> > repodlgs.c:1129: warning: no previous prototype for `unit_is_obsolete'
> > make[3]: *** [repodlgs.o] Fehler 1
> > 
> 
> Hmm, I don't think it complained when I compiled it.  I'll fix it anyway.

Note the extra -W options.

> >  - I had no idea what the "Change in Progress"-button does till I used
> >  it. Maybe "Change currently build" or similar. 
> 
> I thought it was clear, but apparently not.  It was sort of by parralelism
> to the "in prog" column header.  How about "Change building"?

It looks like there is no ideal solution for this little space.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We've all heard that a million monkeys banging on a million typewriters
  will eventually reproduce the entire works of Shakespeare.
  Now, thanks to the Internet, we know this is not true."