[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Jan 05, 2002 at 05:57:35PM +0100, Per I. Mathisen wrote:
> > Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > > If I want a consistent style (K&R) in the CVS tree I have three options:
> > >  1) I fix it
> > >  2) the author fixes it (patch will be rejected because of things like
> > >  "4<5")
> > >  3) the patch goes in unchanged and a followup patch from another
> > >  person should fix it.
> > >
> > > 3) is unacceptable for me. I have the impression that 2) is not
> > > desired by most of the people. So I use 1).
> > >
> > > Ross wants 2) for his patches. This is ok.
> 
> On Sat, 5 Jan 2002, Petr Baudis wrote:
> > I will be happy with 2) as well.
> 
> I must admit I've completely skipped the style guide discussion, and
> haven't even read it. Hence I suspect my patches are totally improper as
> far as style goes. But as long as the style guide is easily available
> somewhere and easily readable, I'd be happy to fix style stuff myself for
> my own patches, if this makes them go into cvs faster.

Note that this last discussion is more about things which indent can
handle. Since the style guide isn't still in the CVS (my fault) I
can't demand this from patch authors.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Windows: From the people who brought you edlin...