Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2002:
[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
Home

[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
From: "Per I. Mathisen" <Per.Inge.Mathisen@xxxxxxxxxxx>
Date: Sat, 5 Jan 2002 17:57:35 +0100 (MET)

> Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > If I want a consistent style (K&R) in the CVS tree I have three options:
> >  1) I fix it
> >  2) the author fixes it (patch will be rejected because of things like
> >  "4<5")
> >  3) the patch goes in unchanged and a followup patch from another
> >  person should fix it.
> >
> > 3) is unacceptable for me. I have the impression that 2) is not
> > desired by most of the people. So I use 1).
> >
> > Ross wants 2) for his patches. This is ok.

On Sat, 5 Jan 2002, Petr Baudis wrote:
> I will be happy with 2) as well.

I must admit I've completely skipped the style guide discussion, and
haven't even read it. Hence I suspect my patches are totally improper as
far as style goes. But as long as the style guide is easily available
somewhere and easily readable, I'd be happy to fix style stuff myself for
my own patches, if this makes them go into cvs faster.

Yours,
Per

Action expresses priorities.
 -- Mohandas Gandhi



[Prev in Thread] Current Thread [Next in Thread]