Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] Tech cost patch v16 (PR#1082)
Home

[Freeciv-Dev] Tech cost patch v16 (PR#1082)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Tech cost patch v16 (PR#1082)
From: Juha Litola <slave@xxxxxxxxxxxx>
Date: Thu, 13 Dec 2001 18:11:28 +0200

On Thu, Dec 13, 2001 at 04:17:34PM +0100, Raimar Falke wrote:
> On Sun, Dec 09, 2001 at 01:40:42PM +0200, Juha Litola wrote:

> > +  if(has_capability("turn", aconnection.capability)) {
> This "turn" looks odd.
Yes, it should be tech_cost_style. Fixed.

> > +  req[tech]++;
> Is this equvialant to "req[tech]=1"?
Yes. Changed.

> find_unknown_req_techs and num_req_techs_rec perform the same
> task. Can you unify them to:
I'm not sure that this is too elegant, but I merged them
to find_requirements-function.

> It is more robust to do
> case 0:
> ...
> case 1:
> case 2:
>   return goal_tech_cost_rec(pplayer, goal);
> default:
>   assert(0);
>   exit(1);
Changed.

Also changed goal_tech_cost to tech_cost_for_reaching_goal and
num_unknown_req_techs to num_requirements.

-- 
// Juha Litola

Attachment: tech_cost_style16.diff.gz
Description: Binary data

Attachment: pgpVxRi9UYkMC.pgp
Description: PGP signature


[Prev in Thread] Current Thread [Next in Thread]