Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] using indent (was: Reproducable core dump (PR#1051))

[Freeciv-Dev] using indent (was: Reproducable core dump (PR#1051))

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] using indent (was: Reproducable core dump (PR#1051))
From: Reinier Post <rp@xxxxxxxxxx>
Date: Sat, 1 Dec 2001 01:08:20 +0100

On Fri, Nov 30, 2001 at 02:43:30PM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:

> Raimar has been reformatting such comments himself - but presumably 
> _after_ he runs indent over the patch.  I'd be quite willing to do this 
> part myself, but it should only be done right before the patch is 
> committed - up until that point, having indent work on the comment is 
> good; otherwise you have to reformat by hand (sometimes many times) and 
> that's way too tedious.

You know, indent is not the only thing we can run the code through.

  perl -pei.c++ 's#//(.*\S)#/*$1 */#' foo.c

(or similar) gets rid of C++-style comments.

> I generally prefer this style of comment, because indent will reformat 
> it as necessary.  For a project like freeciv, though, we probably want 
> to avoid such reformatting so that cvs annotate will work properly.  But 
> still, it should only be done right before the patch is applied IMO.

I've noticed that CVS itself can automatically run code through arbitrary
commands at the time CVS commands are issued.  Has anyone here experimented
with that feature?  Can it smoothen this transition?


[Prev in Thread] Current Thread [Next in Thread]