Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)
Home

[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx, "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 27 Nov 2001 11:55:24 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Nov 11, 2001 at 06:19:17PM +0100, Raimar Falke wrote:
> On Thu, Nov 01, 2001 at 06:26:48AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> > This patch introduces a new topology function,
> > base_real_map_distance().  It performs a similar function to
> > real_map_distance, but also finds a distance vector from the source to
> > the destination coordinate pair.  It also replaces xdist and ydist.
> > 
> > A function like this is absolutely essential for iso-rectangular
> > topologies.  xdist() and ydist() will not work because you cannot find
> > the distance along one coordinate axis independently of the other.
> 
> I changed it a bit. Now real_map_distance, sq_map_distance and
> map_distance follow all the same scheme.
> 
> Comments?

And another one. Changes since last version:
 - change the range of dx in map_distance_vector and document the
 ranges
 - add CHECK_MAP_POS to map_distance_vector
 - change the implementation of is_tiles_adjacent

Please review and comment.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Your mail could not be delivered to the following Address:
  VTCMC.VTLPR@xxxxxxxxxxxxx        ** Unassigned error message **"

Attachment: map_distance_vector2.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]