[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Nov 03, 2001 at 03:17:56AM -0500, Jason Dorje Short wrote:
> Gaute B Strokkenes wrote:
> > 
> > I propose to scrap it entirely, which is what I'm doing.  That is a
> > much better idea than trying to apply a concept (Euclidean metric) to
> > arbitrary nightmare topologies, where it does not have a sensible
> > meaning.
> 
> Yes, although I don't think we can guarantee that it won't ever be
> necessary.
> 

> As for your patch, though, I think you'd be much better off creating a
> new macro (a variant of square_iterate, not sure what it should be
> called) than rewriting the code to not use a macro.  Aside from that,
> all looks good.

I agree. A variant of square_iterate which gives the "raw" offsets
would solve this nicely.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Only one human captain has ever survived battle with the Minbari
  fleet. He is behind me. You are in front of me. If you value your 
  lives, be somewhere else."
    -- Ambassador Delenn, "Severed Dreams," Babylon 5