Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: bug in mapgen (PR#1043)
Home

[Freeciv-Dev] Re: bug in mapgen (PR#1043)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: bug in mapgen (PR#1043)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 11 Nov 2001 17:23:12 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Tue, Nov 06, 2001 at 07:45:03PM -0500, Ross W. Wetmore wrote:
> I would delete the lines. I don't think they are actually used after
> this point, but I didn't do an exhaustive check. Create_island() resets
> them each time, and when you leave at this point you aren't looping
> back to place_island().

Ack.

> Since they are (badly named) globals anybody could access them, but it
> isn't really likely.

Ack.

What about the attached patch?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."

Attachment: mapgen1.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]