Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)
Home

[Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Oct 2001 19:00:16 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Mon, Oct 08, 2001 at 12:42:57PM -0400, Jason Dorje Short wrote:
> Raimar Falke wrote:
> > 
> > On Mon, Oct 08, 2001 at 12:04:15PM -0400, Jason Dorje Short wrote:
> 
> > > +     Care must be taken so that the new height map uses the exact
> > > +     same storage structure as the real one - it must be the same
> > > +     size and use the same indexing.
> > 
> > We don't need the same indexing. The new one just have to hold all the
> > information of the old one. I would use "For this the new map has to
> > be of the same size as the old one".
> 
> With a different indexing scheme, everything will fail catastrophically
> since the new heights will get copied back into the wrong places.  Or do
> you mean it's not an issue since both use map_inx?

Ahh I forgot the memcpy. Yes they both have to use the (same) map_inx
or hmap.

I will apply it shortly.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Despite all the medical advances of the 20th century, the mortality 
  rate remains unchanged at 1 death per person."


[Prev in Thread] Current Thread [Next in Thread]