[Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Raimar Falke wrote:
> 
> On Fri, Oct 05, 2001 at 12:15:26PM -0700, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:

> > -    a += hmap(x, my);
> > -    a += hmap(mx, y);
> > +    /* what about a new macro, adjc_nearest_iterate? */
> > +    for (dir=0; dir<8; dir++) {
> > +      int dx, dy, x2, y2;
> > +      DIRSTEP(dx, dy, dir); /* can't use MAPSTEP */
> > +      x2 = x + dx, y2 = y + dy;
> > +      nearest_real_pos(&x2, &y2);
> 
> What about taking a real adjc_iterate macro and count the real tiles?
> Substitute "/10" by this count. Both methods (your patch and ignoring
> un-real tiles) aren't wrong. They just differ. And we have already
> changed the output of this method.

This would result in less smoothness at the poles - not necessarily bad,
but I see no reason for it.

jason