Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)
Home

[Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: PATCH: fix for smooth_map (PR#991)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Oct 2001 09:33:07 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Mon, Oct 08, 2001 at 12:15:53AM -0400, Jason Dorje Short wrote:
> 
> OK, ok.  nearest_real_tile is a bit iffy anyway, as Gaute pointed out.
> 
> How about this?  It also removes the unnecessary malloc call (which is
> present in other parts of the code...) and fixes a small inconsistency
> with the randomization.

Ok.

>  static void smooth_map(void)
>  {
> +  int new_hmap[map.xsize * map.ysize];

I think that such constructs aren't allow in C. IMHO the size has to
be a compile time constant. Either I'm wrong and this is ok for local
function variables or it is an gcc extension.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "#!/usr/bin/perl -w
  if ( `date +%w` != 1 ) {
    die "This script only works on Mondays." ;
  }"
    -- from chkars.pl by Cornelius Krasel in de.comp.os.linux.misc


[Prev in Thread] Current Thread [Next in Thread]