[Freeciv-Dev] Re: Core is_tiles_adjacent

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Oct 04, 2001 at 03:36:46PM -0700, Paul Zastoupil wrote:
> > Assertion failed: is_tiles_adjacent(punit->x, punit->y, x, y), file
> unittools.c, line 3097
> 
> #0  0xff21b638 in _libc_kill () from /usr/lib/libc.so.1
> #1  0xff1b5644 in abort () from /usr/lib/libc.so.1
> #2  0xff1b58e8 in _assert () from /usr/lib/libc.so.1
> #3  0x264ec in goto_route_execute (punit=0x198868) at unittools.c:3103
> #4  0x35488 in do_unit_goto (punit=0x198868, restriction=GOTO_MOVE_ANY, 
>     trigger_special_ability=1) at gotohand.c:1079
> #5  0x21514 in update_unit_activity (punit=0x198868) at unittools.c:993
> #6  0x2046c in update_unit_activities (pplayer=0xb) at unittools.c:595
> #7  0x40338 in update_player_activities (pplayer=0x1171b8) at plrhand.c:175
> #8  0x153e4 in end_turn () at srv_main.c:420
> #9  0x176ac in main_loop () at srv_main.c:1728
> #10 0x17bd8 in srv_main () at srv_main.c:1970
> #11 0x11ef8 in main (argc=0, argv=0xffbefa24) at civserver.c:147

Mhh

There was a test 

-    if (is_tiles_adjacent(punit->x, punit->y, x, y)) {

in the code before the patch. Gregory removed it in the patch. I added
it as an assert (praise defensive programming). So either I applied
the patch wrong or the patch was itself wrong (which is also my
mistake because I haven't tested it). Gregory?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  What's nice about GUI is that you see what you manipulate.
  What's bad about GUI is that you can only manipulate what you see.