[Freeciv-Dev] Re: [Patch] MAPSTEP

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

From the diff, it looks like you just rediscovered the missing memset
in find_a_direction. 

  /* stack garbage is often >best - clear it now, not in every special case */
  memset(d,0,sizeof(d));
   

Or did I miss something else. There were only a couple places in the 
corecleanup where your patch took, but I carefully haven't converted the GUI 
where there seemed to be more cases.

FYI: the corecleanup is stable wrt autogames, I updated the various
     iteration functions in map.h to use it (using rotational order).

Cheers,
RossW
=====

At 10:52 PM 01/09/22 +0200, Raimar Falke wrote:
>On Sat, Sep 22, 2001 at 02:41:17PM +0200, Raimar Falke wrote:
>> On Sat, Sep 22, 2001 at 01:13:05PM +0100, Gregory Berkolaiko wrote:
>> >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
[...]
>I found one error. Unfortunately you can't compare them because the
>old/current code is buggy. It uses unreal positions. Try the attached
>patch and watch.
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "When C++ is your hammer, everything looks like a thumb."
>    -- Steven M. Haflich
>
>Attachment Converted: "c:\program files\eudora\attach\dir_dx_remove3.diff"
>
>Attachment Converted: "c:\program files\eudora\attach\extra_assert.diff"
>