[Freeciv-Dev] Re: [Patch] MAPSTEP

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Sat, Sep 22, 2001 at 01:13:05PM +0100, Gregory Berkolaiko wrote:
[...]
> > However I strongly object to your use of _MAPSTEP because:
> > 1. It obscures the code.
> > 2. It is unnecessary.
> > 3. It's got bad name (MAPSTEP_FROM_0 would be better if you insist on
> > using it).
> 
> I introduced it for the case you mentioned below. You may have a way
> to express this without an extra macro besides MAPSTEP.

Errr, actually my complaint was about you use of _MAPSTEP exactly in the
case mentioned below.  Why do you want to get rid of DIR_D[XY] ?
They've got good name, it's transperent what it does etc.
I don't think you are making code any more readable/general by using this
ugly _MAPSTEP.

> @@ -2083,8 +2067,9 @@
>    get_canvas_xy(x, y, &canvas_src_x, &canvas_src_y);
>    canvas_src_x += NORMAL_TILE_WIDTH/2;
>    canvas_src_y += NORMAL_TILE_HEIGHT/2;
> -  canvas_dest_x = canvas_src_x + (NORMAL_TILE_WIDTH * DIR_DX[dir])/2;
> -  canvas_dest_y = canvas_src_y + (NORMAL_TILE_WIDTH * DIR_DY[dir])/2;
> +  _MAPSTEP(canvas_dest_x, canvas_dest_y, dir);
> +  canvas_dest_x = canvas_src_x + (NORMAL_TILE_WIDTH *
canvas_dest_x)/2;

Best,
G.


____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie