[Freeciv-Dev] Re: [Patch] MAPSTEP

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Sep 23, 2001 at 12:10:41AM -0400, Ross W. Wetmore wrote:
> >From the diff, it looks like you just rediscovered the missing memset
> in find_a_direction. 

Yes.

>   /* stack garbage is often >best

You can't trust stack garbage. It is simply uninitialized.

> - clear it now, not in every special case */
>   memset(d,0,sizeof(d));
>    
> 
> Or did I miss something else. There were only a couple places in the 
> corecleanup where your patch took, but I carefully haven't converted the GUI 
> where there seemed to be more cases.
> 
> FYI: the corecleanup is stable wrt autogames, I updated the various
>      iteration functions in map.h to use it (using rotational order).

What are you talking about I didn't find anything in the incoming.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The trick is to keep breathing.