[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been put in incoming

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Raimar Falke wrote:
> 

> > Your comment
> > +  /* FIXME: The GUI uses DIR_DX directions */
> > isn't clear because "DIR_DX" isn't well defined.  How about calling them
> > "vertical" directions (instead of rotational directions)?  That's what
> > you mean, right?
> 
> I removed the comments because it is clear that something which does
> "int x1=x+DIR_DX[dir];" is using DIR_DX directions.

But it is not immediately clear that that is why adjc_iterate (or
adjc_dir_iterate) cannot be used, and 7-dir must be used instead of
DIR_REVERSE(dir).  Some form of comment is in order.

jason