[Freeciv-Dev] [PATCH] Corecleanup_07Part1 has been put in incoming

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 08:01 AM 01/08/24 +0200, Raimar Falke wrote:
>On Wed, Aug 22, 2001 at 06:04:45PM +0200, Raimar Falke wrote:
>> You were really hard-working. Besides this things above I like the
>> patch. However it is just too big. Can you please make several
>> patches: one replacing square_iterate, one replacing adjc_iterate, one
>> whole_map_iterate, one city_map_iterate_checked and one with the rest
>> and the cases above?
>
>Should I do the split or will you do it?
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
>  This customer comes into the computer store. "I'm looking for a mystery
>  Adventure Game with lots of graphics. You know, something realy
>  challenging". "Well," replied the clerk, "have you tried Windows 98 ?"

Attached is the corecleanup_07.ReadMe for Part1 of the rev of corecleanups
to cvs-Aug-25. This contains only updates to corecleanup_06a including 
fixes for reviewer comments, and a split into smaller chunks based on
type as requested by Raimar and file to avoid patch order issues.

Unless there is some serious new problem, I hope this can be speedily 
applied to CVS. It should be sufficiently reviewed, stable and tested 
that minor issues can be resolved as regular bugfixes.

Cheers,
RossW
=====

This is the first part of corecleanup_07, resubmission of corecleanup_06a
with applied fixes from review comments.

The rest will follow as soon as I catch my breath.


The following patches were produced as follows:

1)  Changes to CVS Aug-23 were merged to rev the corecleanup_06 source.
2)  After the merge, each source was updated with any minor changes. 
3)  The result ran autogames for 18 hours on at 8-9 games/hr w/o fail.
4)  Changes to CVS Aug-25 were merged to rev the source.
5)  After the merge, each source was updated with any minor changes. 
6)  The result ran autogames for 4 hours on at 8-9 games/hr w/o fail.
7)  Patches were made by diffing against the Aug-25 source.
8)  These final patches were tested by applying them in sequence to an
    Aug-25 snapshot, with build and sanity test run at each step.

-rw-r--r--  1 rww   users   4053 Aug 25 18:30 corecleanup_07.ReadMe
-rw-r--r--  1 rww   users   8034 Aug 25 18:14 corecleanup_07a
-rw-r--r--  1 rww   users  26698 Aug 25 14:16 corecleanup_07b
-rw-r--r--  1 rww   users  11438 Aug 25 14:13 corecleanup_07c
-rw-r--r--  1 rww   users  16027 Aug 25 14:17 corecleanup_07d
-rw-r--r--  1 rww   users  12909 Aug 25 14:16 corecleanup_07e

wc output:
     15      30     640 corecleanup_07.ReadMe
    223     997    7398 corecleanup_07a
    744    3985   26698 corecleanup_07b
    327    1586   11438 corecleanup_07c
    439    2145   16027 corecleanup_07d
    331    1206   12909 corecleanup_07e

Corecleanup_07a is required, or at least the trivial map.h fix. The
rest are complete file subsets of corecleanup_06a plus updates from
various reviews, split into <500 lines where feasible, with grouping
into sets for adjacent_iterate, whole_map_iterate, square_iterate, 
city_map_iterate, misc GUI cleanups.

Cheers,
RossW
=====


Subject:  [Patch4cvs] Corecleanup_07a patch
Date:     Aug 26, 2001
Author:   Ross Wetmore
Status:   Tested
State:    ReSubmission of corecleanup_06a

Description
  This patch contains all adjacent_iterate updates not found elsewhere
plus the critical nitfix to map.h.

Dependencies
  none

Files Changed:
corecleanup-07a: freeciv/client/climisc.c
corecleanup-07a: freeciv/client/goto.c
corecleanup-07a: freeciv/common/map.h
=====


Subject:  [Patch4cvs] Corecleanup_07b patch
Date:     Aug 26, 2001
Author:   Ross Wetmore
Status:   Tested
State:    ReSubmission of corecleanup_06a

Description
  This patch contains all the whole_map_iterate updates. Gotohand.c
is the bulk of this, but much is tab/indentation changes from a double
for to single loop construct, plus general noise as in d[k] to d[dir]
i.e. updated loop variables.

Dependencies
  corecleanup_07a: map.h

Files Changed:
corecleanup-07b: freeciv/client/packhand.c
corecleanup-07b: freeciv/server/gotohand.c
=====


Subject:  [Patch4cvs] Corecleanup_07c patch
Date:     Aug 26, 2001
Author:   Ross Wetmore
Status:   Tested
State:    ReSubmission of corecleanup_06a

Description
  This patch contains all square_iterate updates.

Dependencies
  corecleanup_07a: map.h

Files Changed:
corecleanup-07c: freeciv/ai/aiunit.c
corecleanup-07c: freeciv/client/control.c
=====


Subject:  [Patch4cvs] Corecleanup_07d patch
Date:     Aug 26, 2001
Author:   Ross Wetmore
Status:   Tested
State:    ReSubmission of corecleanup_06a

Description
  This patch contains all city_map_iterate updates.

Dependencies
  corecleanup_07a: map.h

Files Changed:
corecleanup-07d: freeciv/ai/advdomestic.c
corecleanup-07d: freeciv/common/city.h
corecleanup-07d: freeciv/server/cityturn.c
corecleanup-07d: freeciv/server/settlers.c
=====



Subject:  [Patch4cvs] Corecleanup_07e patch
Date:     Aug 26, 2001
Author:   Ross Wetmore
Status:   Tested
State:    ReSubmission of corecleanup_06a

Description
  This patch contains all miscellaneous and client-GUI changes.

Dependencies
  corecleanup_07a: map.h

Files Changed:
corecleanup-07e: freeciv/client/gui-gtk/mapview.c
corecleanup-07e: freeciv/client/gui-xaw/mapview.c
corecleanup-07e: freeciv/client/tilespec.c
corecleanup-07e: freeciv/server/sanitycheck.c
=====