[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been put in incoming

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Raimar Falke wrote:
> 
> On Sun, Aug 26, 2001 at 10:18:07AM -0400, Ross W. Wetmore wrote:
> > The GUI currently has its own hardwired direction system that has not been
> > and should not be merged with the adjacent and standardizing core system
> > until the GUI problems are fixed.
> 
> AFAIK the GUI used either DIR_DX or DIR_DX2. If this is the case, why
> don't we let the global system the one of the gui? At least as an
> intermediate step.

DIR_DX2 is only used in one file, and would easily be removed - then
everything would be using DIR_DX, and we could spend some time finding
"magic" numbers and fixing the GUI so that everything worked
independently of the direction schema.  However, Ross believes the
rotational schema (currently used by DIR_DX2) is so much better than the
vertical one that it's more important to switch over to it immediately
even if it means using 2 directional systems for a while.  Ross, can you
give more explanation?

> >> > I looks like I have missed something about the
> >> > "7-dir"-vs-"DIR_REVERSE(dir)".  DIR_REVERSE(dir) is currently doing the
> >> > correct thing.
> 
> I'm beginning to regret not landing all over this one when it first went
> in. I had assumed people would pickup on the change and reason when they
> were reversed later, and arguing it at the time would have been talking
> to a deaf mule. :-)

Yes, at the time I didn't realize there was a problem with this
(although again, I don't think your way is the correct way to solve it).

jason