[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been put in incoming

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Aug 25, 2001 at 07:02:22PM -0400, Ross W. Wetmore wrote:

> Subject:  [Patch4cvs] Corecleanup_07c patch

-  for( i = 1-search_dist; i < search_dist; i++ ) {
-    for( j = 1-search_dist; j < search_dist; j++ ) {
-      xx = map_adjust_x(punit->x + i);
-      yy = map_adjust_y(punit->y + j);
+  square_iterate(punit->x,punit->y, search_dist, xx,yy) {

IMHO this has to be
+  square_iterate(punit->x,punit->y, search_dist - 1, xx,yy) {

-    for (dx = -1; dx <= 1; dx++) {
-      for (dy = -1; dy <= 1; dy++) {
-       x = map_adjust_x(leader->x + dx);
-       y = map_adjust_y(leader->y + dy);
-       if (warmap.cost[x][y] > safest
+    adjc_iterate(leader->x,leader->y, x,y) {
+      if (warmap.cost[x][y] > safest

IMHO this is a square_iterate instead of an adjc_iterate.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  One nuclear bomb can ruin your whole day.