[Freeciv-Dev] Re: [bug cvs] I want my city walls back ! (improvement_redundant buggy) (PR#906) - fix

[Francois Taiani <francois.taiani@xxxxxxxx>]

Sebastian Bauer wrote:
> 
> Hi!
> 
Hi Sebastian,

in your diff you have the following line

+   return
BOOL_VAL(game.global_advances[improvement_types[id]obsolete_by]);

which causes the following compilation error when I try to compile it:
------------
cd /home/ftaiani/downloads/freeciv-cvs-Aug-23-underwork/common/
make -k 
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl    -g -O2 -Wall -c
improvement.c
improvement.c: In function `improvement_obsolete':
improvement.c:274: parse error before `obsolete_by'
make: *** [improvement.o] Error 1
make: Target `all' not remade because of errors.
------------
Could a period be missing before obsolete_by ?

Gruesse

Francois

> From: "Sebastian Bauer" <sebauer@xxxxxxxxxxx>
> > From: "Greg Wooledge" <greg@xxxxxxxxxxxx>
> > > Of course, as soon as the Great Wall becomes obsolete, you should once
> > > again be able to build City Walls, Metallurgy being irrelevant in that
> > > respect.
> > Ok, fix will follow soon.
> 
> Attached.
> 
>  bye,
> Sebastian Bauer
> 
>   ------------------------------------------------------------------------
>                    Name: freeciv.diff
>    freeciv.diff    Type: unspecified type (application/octet-stream)
>                Encoding: quoted-printable