[Freeciv-Dev] Re: patch: Modified can_build_improvment()

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

>
>> > May I remove equiv_dupl?
>>
>> IMHO, no. For example, the Barracks has
>> equiv_dupl      = "Barracks II", "Barracks III"
>> equiv_repl      = "Sun Tzu's War Academy"
>>
>> i.e. you're not allowed to have both a Barracks and a Barracks
>> II, but if you have the War Academy you can still build a Barracks - it
>> just won't have any effect. (Personally I think the two names are
>> confusing, but I do see the need for both.)
>
>Hmm...confusing. But then the description which is inside the
>buildings.ruleset is not correct, if I haven't misunderstood this. The
>description of equiv_dupl is:
>"list of buildings that duplicate this building if this city is within that
>building's range (may still build this, but will have no effect)". IMO this
>is the opposite what you say. So you could (according to the description)
>build "Barracks II" and "Barracks III", if there wasn't the obsolette entry.
>Another problem here are the differnt power plants:
>
>equiv_dupl = "Power Plant", "Nuclear Plant", "Solar Plant"
>equiv_repl = "Hoover Dam"
>
>If I haven't tested it now and I usally don't play Freeciv but if I look
>inside the code you can only build one power plant type. In this case it is
>the same like you said in the example. But you also cannot build any power
>plant if you have the "Hoover Dam". Besides you also cannot build (again
>inside the current code) a "Barracks" if you have the "Sun Tzu's War
>Academy". Or all the other wonder replacemets (Pyramids,...). Of course you
>still could have "Barracks" if you have the "Sun Tzu's War Academy" but you
>cannot but them any longer once you have the "Sun Tzu's War Academy" (and
>its not obsolette)
>
>All in all I still don't see the sense in these two entries. Equiv_repl is
>IMO enough.

Hi.  I'm the one who (last) touched this stuff (others had started it).

I *don't* see how equiv_repl is enough.  Both equiv_dupl and equiv_repl
specify something that provides an effect, but you are not allowed to build
the equiv_dupl things, while you are still allowed to build the equiv_repl
things.

How would you encode that difference without the two items?


jjm