[Freeciv-Dev] Re: [patches] freeing NULL ptrs

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Aug 19, 2001 at 04:52:55PM -0400, Justin Moore wrote:
> 
> > Could the dropping core be make explicit "assert(0);"?
> 
>    Done.  And since the error is (possibly) non-fatal, I've changed it to
> a LOG_ERROR instead of LOG_FATAL.  Patch is included.

The patch is technically correct. However I'm not sure if we need
this. In my experience there weren't only very few errors which
fc_free() would get catched. And free(NULL); is also a noop. On the
other side it could by made symmetric to fc_malloc.

What do other people think about this?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx