[Freeciv-Dev] Re: [patches] freeing NULL ptrs

[Kevin Brown <kevin@xxxxxxxxxxxxxx>]

Justin Moore <justin@xxxxxxxxxxx> wrote:
> 
>    Some allocation and freeing tools turned up a few places where we were
> freeing NULL pointers in common/registry.c and server/ruleset.c.  Patches
> against 1.12.0 included.  I had suspected there was some heap corruption
> going on, but didn't know exactly where until now.
> 
> -jdm
> 
> PS. Would it be worth it to create a fc_free that ignores all NULL
> pointers passed to it?

Probably.  It might be helpful, too, to have that same function
assert(ptr != NULL) first if compiled with debugging turned on, so
that any instances where the code tries to free a NULL can be tracked
down and, if necessary, fixed.


-- 
Kevin Brown                                           kevin@xxxxxxxxxxxxxx

    It's really hard to define what "unexpected behavior" means when you're
                       talking about Windows.