Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)
Home

[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Sun, 19 Aug 2001 13:14:45 -0700 (PDT)

On Sun, 19 Aug 2001, Raimar Falke wrote:
> On Sun, Aug 19, 2001 at 12:52:58PM -0700, Trent Piepho wrote:
> > On Sun, 19 Aug 2001, Arien Malec wrote:
> > > Thought I sent this, but didn't see it on list (user error, no doubt)
> > > 
> > > Corrected patch is attached. Note that I tried to play nicely with the
> > > surrounding code, and didn't do a wholesale indent -kr -i2 in the areas I 
> > > was
> > > editing.
> > 
> > When you add a new field to a packet, you should add it at the end.
> 
> This isn't necessary. Since the reading and writing is guarded by
> has_cap() calls there is no problem.

Are you saying the server and client know to skip the pop_cost field if the
capability is missing?  Or that they won't be allowed to talk at all?




[Prev in Thread] Current Thread [Next in Thread]