Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)
Home

[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Arien Malec <arien_malec@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 19 Aug 2001 19:49:39 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Aug 19, 2001 at 09:39:25AM -0700, Arien Malec wrote:
> Thought I sent this, but didn't see it on list (user error, no doubt)
> 
> Corrected patch is attached. Note that I tried to play nicely with the
> surrounding code, and didn't do a wholesale indent -kr -i2 in the areas I was
> editing.

IMHO it doesn harm to indent the surrounding block.

Could you remove the extra newlines at the end of some files?

> @@ -70,7 +70,7 @@
>   * are not directly related to the capability strings discussed here.)
>   */
> 
> -#define CAPABILITY "+1.11.6 conn_info"
> +#define CAPABILITY "+1.11.6 conn_info pop_cost"
> 
>  /* "+1.11.6" is protocol for 1.11.6 beta release.

Normally the new capability is described below. See old sources for
examples.

        Raimar

P.S.: Does anybody using mutt know how to teach mutt to treat
"text/x-diff" as "text/plain". Mutt wouldn't include the "text/x-diff"
attachment in a reply. I can manually add the diff but then I also
have to manually quote the diff. It is no big (s/^/> /) but still
extra work

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "From what I am reading Win98 and NT5.0 will be getting rid of all that
  crap anyway. Seems that Microsoft has invented something called TCP/IP and
  another really revolutionary concept called DNS that eliminates the
  netbios crap too. All that arping from browsers is going to go away.
  I also hear rumors that they are on the verge of breakthrough discoveries
  called NFS, and LPD too. Given enough time and money, they might
  eventually invent Unix."
    -- George Bonser in linux-kernel


[Prev in Thread] Current Thread [Next in Thread]