[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 16, 2001 at 04:47:35PM -0700, Arien Malec wrote:
> Raimar --
> 
> I can't find any place where the patch doesn't do -kr -i2? Could you please
> point them out?

> @@ -468,7 +479,7 @@
>        }
>        else if(improvement_exists(B_SEWER)
>             && !city_got_building(pcity, B_SEWER)
> -           && pcity->size >= game.sewer_size) {
> +           && pcity->size+unit_pop_value(punit->type) > game.sewer_size) {

At least my indent would put extra spaces before and after the "+".

>       notify_player_ex(pplayer, punit->x, punit->y, E_NOEVENT,
>                        _("Game: %s needs %s to grow, so you cannot add %s."),
>                        pcity->name, get_improvement_name(B_SEWER),

> As for capabilities: the changes are back-end and don't require the client and
> server to agree on anything. The only change at all to the client is to pick 
> up
> the pop_cost field of the struct (hm, I suspose that might crash the client?)

> Would adding "pop_cost" to the CAPABILITY define be suffient?

Yes.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  One nuclear bomb can ruin your whole day.