[Freeciv-Dev] Re: Map coordinate cleanups.

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Thu, 16 Aug 2001, jshort@xxxxxxxxxxxxx wrote:
> 
> > 1.  The only reason to make these functions macros is speed.  Speed
> > is a small concern compared to the possibility of having multiple
> > topologies.
> 
> Don't belive everything you're told on freeciv-dev.  8-) As it stands
> now, the possibility of having multiple topologies is in no way, shape
> or form related to whether or not it is feasible to use a macro here.
> The only case in which I can even see a macro possibly not being
> adequate is if we ever implement `isometric view' shapes, and even
> them I'm doubtful.  In any case, you would have to change so much code
> to implement that (including rewriting is_real_tile() from scratch)
> that the 30 seconds that it will take you to search and replace
> IS_REAL_TILE() -> is_real_tile() is the least of your worries.

Are you saying there is a reason other than speed to make them macros?

Well, never mind.  You're right that the work necessary to convert them
back is minimal.  There is a _lot_ of work ahead before an isometric map
would be possible (although I'm not too worried about is_real_tile; it's
only one line).  The biggest problem is replacing all map_adjust_[xy]
macro uses with normalize_map_pos (or whatever macro you come up with to
replace it).

I still disagree with you on the nomenclature.

jason