[Freeciv-Dev] Map coordinate cleanups.

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

Attached is patch that fixes several instances where Freeciv
inadvertently creates unnormalised map coordinates or makes use of
unreal map coordinates.  It also changes the is_real_tile() function
to a macro IS_REAL_TILE(), and adds macros IS_NORM_TILE() and
IS_PROP_TILE(), and some other coordinate related things.

I am able to run long AI games with this patch without any changes (as
measured by examining savegame files).

My eventual goal is to eliminate all such instances completely, and to
get rid of void_tile.  I have more fixes in my local tree, but I'm not
applying them since they seem to cause subtle differences in the
behaviour of the AI, and I don't want to have to drag all of this with
me until I get it licked, particularly since others are doing some
work in the same area.

Unless anyone objects, I will apply this soon after adding some
explanatory comments to the new macros.  It would be nice if someone
could verify that the GTK and MUI clients do not go bananas with this
patch, since I can't test them myself.

map.diff
Description: Text document

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Are we THERE yet?