[Freeciv-Dev] 'goto' prefers the path via ship (PR#888)

[mriser@xxxxxxx]

Full_Name: Micha Riser
Version: 1.12.0
Distribution: Built from source
Client: Gtk+
OS: Linux
Submission from: (NULL) (217.162.108.65)


Consider following: A horse two moves from an enemy city away. It is on a
coastal square, at the coast is a transport which is between the horse and the
city, that means from the horse it is two moves on land to reach the city, but
also two moves when it goes on the ship and then into the city.

The 'goto' function will use the path going via the transport. But the move
fails because after it is on the ship it cannot directly move into the enemy
city (as land units cannot attack from water).

In this situation 'goto' should prefer the land way. (Maybe it is even always
better to go on land??)

Savegame is at http://www.povworld.de/civgotobugs.sav.gz . Connect as 'Human'
and end the turn. Now 'goto' the Cavalry to the city Conception. - And yet you
have it on board of the ship instead of attacking the city.