[Freeciv-Dev] Re: Ping patch

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Feb 17, 2001 at 04:20:16PM +0000, Vasco Alexandre Da Silva Costa wrote:
> On Sat, 17 Feb 2001, Raimar Falke wrote:
> > On Sat, Feb 17, 2001 at 03:41:08PM +0000, Vasco Alexandre Da Silva Costa 
> > wrote:
> > > * Also, added a max size of MAX_LEN_BUFFER to the send buffers,
> > >   if the send buffer gets bigger than 128kb the player's connection is 
> > > cut.
> > >   This is just in case something freaky happens & the send buffer starts
> > >   eating mem like a black hole.
> > 
> > There is currently no mechanism which limits this otherwise?
> 
> Nope.  But i don't think 1.11.4 had a dynamic send buffer.  How it was it
> only failed if it couldn't realloc the buffer.
> 
> > > Of course, because of the ping packets, this breaks network protocol
> > > compatibility.  Yes i know we can use the capability string and just not
> > > send these packets to older clients but i don't want to do that.
> > > I want everyone to be forced to have this behaviour.
> > 
> > So an old client will get an unknown paket, will not get answer and
> > the server will cut the connection?! IMHO this is bad.
> 
> Why is is?  If we're breaking the protocol anyway in this version.
> Aren't we?  I think we are...

In what version? The upcoming 1.12? Do you know when this version will
get released and when your patch gets integrated?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Make a software that is foolproof, and only fools will want to use it.