[Freeciv-Dev] Re: Ping patch

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Feb 17, 2001 at 03:41:08PM +0000, Vasco Alexandre Da Silva Costa wrote:
> This patch adds 2 things:
> 
> * added PACKET_CONN_PING & PACKET_CONN_PONG:
>   PACKET_CONN_PING is sent by the server every GAME_DEFAULT_PINGTIMEOUT
>   seconds to all clients.
>   If the client doesn't reply with PACKET_CONN_PONG by the time the server
>   tries to PING it again the client's connection is cut.
> 
>   GAME_DEFAULT_PINGTIMEOUT is 60 seconds right now.
> 
>   Since these packets don't include any info besides the type of the
>   packet and there was already a packet type called PACKET_BEFORE_NEW_YEAR
>   that was like this i renamed the functions & structs of that to
>   .*packet_generic_empty to reuse code.

Sounds nice.

> * Also, added a max size of MAX_LEN_BUFFER to the send buffers,
>   if the send buffer gets bigger than 128kb the player's connection is cut.
>   This is just in case something freaky happens & the send buffer starts
>   eating mem like a black hole.

There is currently no mechanism which limits this otherwise?

> Of course, because of the ping packets, this breaks network protocol
> compatibility.  Yes i know we can use the capability string and just not
> send these packets to older clients but i don't want to do that.
> I want everyone to be forced to have this behaviour.

So an old client will get an unknown paket, will not get answer and
the server will cut the connection?! IMHO this is bad.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx